os.path.join -> urljoin to allow windows support #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows path uses
\
instead/
for filesystem paths, which becomes a problem when one uses os.path.join to join URLs (which is otherwise fine on linux, a URL is a path after all). Definitely deserves a 2.4.1 or 2.5.0 release, as this is a blocker for one of Brian's students working on Scope.(PS: I'll do the version number change in a separate PR as usual)