-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VDO-5704] Ingest doc typo fixes #47
Merged
lorelei-sakai
merged 11 commits into
dm-vdo:main
from
lorelei-sakai:ingest/doc-typo-fixes
Feb 27, 2024
Merged
[VDO-5704] Ingest doc typo fixes #47
lorelei-sakai
merged 11 commits into
dm-vdo:main
from
lorelei-sakai:ingest/doc-typo-fixes
Feb 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No functional modification involved. src/c++/vdo/base/vdo.c:276: warning: expecting prototype for vdo_read_geometry_block(). Prototype was for read_geometry_block() instead. Reported-by: Abaci Robot <[email protected]> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8273 Signed-off-by: Jiapeng Chong <[email protected]> Signed-off-by: Matthew Sakai <[email protected]>
No functional modification involved. src/c++/vdo/base/slab-depot.c:2042: warning: expecting prototype for vdo_find_free_block(). Prototype was for find_free_block() instead. src/c++/vdo/base/slab-depot.c:5036: warning: expecting prototype for get_depot_slab_journal_statistics(). Prototype was for get_slab_journal_statistics() instead. Reported-by: Abaci Robot <[email protected]> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8274 Signed-off-by: Jiapeng Chong <[email protected]> Signed-off-by: Matthew Sakai <[email protected]>
No functional modification involved. src/c++/vdo/base/physical-zone.c:268: warning: expecting prototype for vdo_free_pbn_lock_pool(). Prototype was for free_pbn_lock_pool() instead. Reported-by: Abaci Robot <[email protected]> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8275 Signed-off-by: Jiapeng Chong <[email protected]> Signed-off-by: Matthew Sakai <[email protected]>
No functional modification involved. src/c++/vdo/base/logical-zone.c:303: warning: expecting prototype for void attempt_generation_complete_notification()(). Prototype was for attempt_generation_complete_notification() instead. Reported-by: Abaci Robot <[email protected]> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8276 Signed-off-by: Jiapeng Chong <[email protected]> Signed-off-by: Matthew Sakai <[email protected]>
No functional modification involved. src/c++/vdo/base/encodings.c:1178: warning: expecting prototype for vdo_decode_component(). Prototype was for decode_vdo_component() instead. Reported-by: Abaci Robot <[email protected]> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8277 Signed-off-by: Jiapeng Chong <[email protected]> Signed-off-by: Matthew Sakai <[email protected]>
No functional modification involved. src/c++/vdo/base/flush.c:97: warning: expecting prototype for waiter_as_flush(). Prototype was for vdo_waiter_as_flush() instead. Reported-by: Abaci Robot <[email protected]> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8278 Signed-off-by: Jiapeng Chong <[email protected]> Signed-off-by: Matthew Sakai <[email protected]>
No functional modification involved. src/c++/vdo/base/dedupe.c:2792: warning: expecting prototype for vdo_dump_hash_zone(). Prototype was for dump_hash_zone() instead. Reported-by: Abaci Robot <[email protected]> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8279 Signed-off-by: Jiapeng Chong <[email protected]> Signed-off-by: Matthew Sakai <[email protected]>
No functional modification involved. src/c++/vdo/base/admin-state.c:310: warning: expecting prototype for vdo_drain_operation(). Prototype was for assert_vdo_drain_operation() instead. Reported-by: Abaci Robot <[email protected]> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8280 Signed-off-by: Jiapeng Chong <[email protected]> Signed-off-by: Matthew Sakai <[email protected]>
Signed-off-by: Matthew Sakai <[email protected]>
Update outdated comments referring to separate VDO and UDS modules. Signed-off-by: Matthew Sakai <[email protected]>
Signed-off-by: Matthew Sakai <[email protected]>
slegendr
approved these changes
Feb 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream commits from vdo-devel/102.