[VDO-5675] Improve constant definitions #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorelei-sakai
changed the title
github-actions
bot
added
private testing running
and removed
private testing running
labels
rhawalsh
approved these changes
Feb 13, 2024
Move static constants from encodings.h to encodings.c to fix upstream compile warnings about unused constants. Upstream these constants are only use in encoding.c. However, these constants are also used in userspace tools and some tests, so internally it's easiest to leave the constants in encodings.h. Add an assertion in encodings.c so that we'll notice the mismatch if we ever change the value of these constants. This is an edit to Susan's earlier commit 9462281cde95 and will be squashed into that one when going upstream. Signed-off-by: Matthew Sakai <[email protected]>
Avoids unconventional use of 'static const' and enum in headers. Signed-off-by: Mike Snitzer <[email protected]> Signed-off-by: Matthew Sakai <[email protected]>
lorelei-sakai
force-pushed
the
feature/improve-constant-defs
branch
from
4c46f98 to
c21d20c
Compare
github-actions
bot
added
private testing running
and removed
private testing running
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upstream commits from vdo-devel/83.
The first of these commits will be squashed with Susan's earlier commit 6f22c72 when going upstream, as per Mike's suggestions.