Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response detections #7

Draft
wants to merge 18 commits into
base: dlt-experiment
Choose a base branch
from
Draft

Response detections #7

wants to merge 18 commits into from

Conversation

steinitzu
Copy link
Collaborator

@steinitzu steinitzu commented Mar 20, 2024

So far addresses some of the points in #5

  1. Detect payload schema by comparing response schema with all other endpoints: https://github.com/dlt-hub/dlt-init-openapi/blob/response-detections/openapi_python_client/parser/responses.py#L32

    Works pretty well so far, but found some cases where it picks the wrong path

  2. Some improvements detecting list/single item endpoints. Lot of that comes from 1.

  3. Currently have basic detection for offset and cursor pagination. Only using property name and types for this atm, looking for the least nested property matching "cursor", etc. https://github.com/dlt-hub/dlt-init-openapi/blob/response-detections/openapi_python_client/parser/pagination.py#L1

  4. Transformers with multiple path params supported. Only when all path params resolve to corresponding properties in parent schema

  5. Fix resource/transformer arguments order, remove pagination args

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant