Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Angular 18 and standalone API #247

Merged
merged 34 commits into from
Oct 23, 2024
Merged

Update to Angular 18 and standalone API #247

merged 34 commits into from
Oct 23, 2024

Conversation

boeckMt
Copy link
Member

@boeckMt boeckMt commented Oct 14, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

  • Angular has been updated to version ^18.2.8
  • Components have been converted to the new standalone API from Angular.
  • Component templates have been converted to the new control flow from Angular.
  • Some styles have been fixed for the clr v17 update that were not correct.
  • Fixed icon direction of cds icons
  • Some dependencies have been updated

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Is it part of one/more packages and which?

boeckMt added 28 commits October 4, 2024 15:51
Copy link

socket-security bot commented Oct 14, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@angular-devkit/[email protected] None 0 169 kB google-wombot
npm/@angular-devkit/[email protected] environment, filesystem, network, shell, unsafe Transitive: eval +259 343 MB google-wombot
npm/@angular-devkit/[email protected] eval, network Transitive: environment, filesystem +15 1.87 MB google-wombot
npm/@angular-devkit/[email protected] None 0 254 kB google-wombot
npm/@angular/[email protected] None 0 1.73 MB google-wombot
npm/@angular/[email protected] None 0 8.58 MB google-wombot
npm/@angular/[email protected] environment, filesystem, network, shell, unsafe Transitive: eval +40 4.64 MB google-wombot
npm/@angular/[email protected] None 0 11.5 MB google-wombot
npm/@angular/[email protected] Transitive: environment, filesystem, unsafe +45 15.4 MB google-wombot
npm/@angular/[email protected] None 0 9.26 MB google-wombot
npm/@angular/[email protected] None 0 21.1 MB angular, google-wombot
npm/@angular/[email protected] None 0 1.98 MB google-wombot
npm/@angular/[email protected] None 0 20.9 MB google-wombot
npm/@angular/[email protected] None 0 81 kB google-wombot
npm/@angular/[email protected] None 0 765 kB google-wombot
npm/@angular/[email protected] None 0 2.44 MB google-wombot
npm/@cds/[email protected] Transitive: environment +7 11.3 MB clarity-service-account
npm/@cesium/[email protected] network Transitive: filesystem +14 31.3 MB jjhembd
npm/@cesium/[email protected] None 0 968 kB jjhembd
npm/@clr/[email protected] None 0 11 MB clarity-service-account
npm/@clr/[email protected] None 0 4.16 MB clarity-service-account
npm/@compodoc/[email protected] filesystem Transitive: environment, network, shell, unsafe +208 54.1 MB compodoc
npm/@schematics/[email protected] None 0 9.87 MB angular, google-wombot
npm/@types/[email protected] None 0 57.8 kB types
npm/@types/[email protected] None 0 2.21 MB types
npm/[email protected] filesystem 0 397 kB sgravrock
npm/[email protected] Transitive: environment, filesystem, shell +10 329 kB sgravrock
npm/[email protected] environment, filesystem, network, shell Transitive: eval, unsafe +49 3.92 MB karmarunnerbot

🚮 Removed packages: npm/@angular-devkit/[email protected], npm/@angular-devkit/[email protected], npm/@angular-devkit/[email protected], npm/@angular-devkit/[email protected], npm/@angular/[email protected], npm/@angular/[email protected], npm/@angular/[email protected], npm/@angular/[email protected], npm/@angular/[email protected], npm/@angular/[email protected], npm/@angular/[email protected], npm/@angular/[email protected], npm/@angular/[email protected], npm/@angular/[email protected], npm/@angular/[email protected], npm/@angular/[email protected], npm/@cds/[email protected], npm/@cesium/[email protected], npm/@cesium/[email protected], npm/@clr/[email protected], npm/@clr/[email protected], npm/@compodoc/[email protected], npm/@schematics/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Copy link

socket-security bot commented Oct 14, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteCI
Protestware or potentially unwanted behavior npm/[email protected]
  • Note: The script attempts to run a local post-install script, which could potentially contain malicious code. The error handling suggests that it is designed to fail silently, which is a common tactic in malicious scripts.
⚠︎

View full report↗︎

Next steps

What is protestware?

This package is a joke, parody, or includes undocumented or hidden behavior unrelated to its primary function.

Consider that consuming this package may come along with functionality unrelated to its primary purpose.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@boeckMt
Copy link
Member Author

boeckMt commented Oct 21, 2024

@lucas-angermann this 79ee484 was the cause of the build dist errors.
Because of these imports, we had multiple different instances of the service that were causing these problems.

Copy link
Member Author

@boeckMt boeckMt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A you found another one, thanks for the fix.
I think this happened through the automatic migration to the standalone API.

@lucas-angermann
Copy link
Contributor

Yes, the bug prevented the 3D terrain to load in the local build. Now it works again. As far as I can see, the remaining demo apps work as usal.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should check the tutorial after the PR with a fresh installation and also look at the map-cesium readme.

Copy link
Contributor

@lucas-angermann lucas-angermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes and fixes!

@boeckMt boeckMt merged commit 91d4dbd into main Oct 23, 2024
16 checks passed
@boeckMt boeckMt deleted the update branch October 23, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants