-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Momento stackable and update recipe #6
Conversation
so that it can implode itself and your crossbow simultaneously
I was going cross-eyed looking at Klin's code trying to understand if this would interfere with onion ring |
It wouldn't, due to the last commit I put in |
Correction: It never would have, since PlayerInventory.getContents() doesn't (to my knowledge) return the offhand |
From checking the javadocs, PlayerInventory inherits getContents from Inventory, and that does return every slot |
From what I can tell (both googling and checking docs) it doesn't return getArmorContents? |
It also doesn't return getExtraContents but I can't figure out what's in extraContents |
Indexes 36 through 39 are the armor slots. Index 40 is the offhand slot. And getContents returns the entire ItemStack array. That includes what getExtraContents would return. For a player, getExtraContents would probably be the crafting slots and crafting result slot. Those are probably after index 40. |
Interesting! Either way, with the last commit I pushed, it doesn't matter since onion ring only deletes your weapon (and itself) if keepInventory is off |
No description provided.