Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable] LDC: Fix ddox regression (prevent colliding HTML output files) #2994

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

kinke
Copy link
Contributor

@kinke kinke commented Jan 24, 2025

No description provided.

Copy link

Thanks for your Pull Request and making D better!

This comment will automatically be updated to summarize some statistics in a few minutes.

@Geod24
Copy link
Member

Geod24 commented Jan 24, 2025

Doesn't fix it I think:

/home/mlang/dlang/ldc-1.39.0/bin/ldc2 -o- -w -lowmem -Xf=docs.json -Df=__dummy.html -d-version=_GLIBCXX_USE_CXX98_ABI -d-version=Have_barcode -d-debug=AgoraDebugAPIs -Isubmodules/barcode/source/ submodules/barcode/source/barcode/code128.d submodules/barcode/source/barcode/code39.d submodules/barcode/source/barcode/ean13.d submodules/barcode/source/barcode/itf.d submodules/barcode/source/barcode/package.d submodules/barcode/source/barcode/qr/ecl.d submodules/barcode/source/barcode/qr/package.d submodules/barcode/source/barcode/qr/qrcode.d submodules/barcode/source/barcode/qr/qrsegment.d submodules/barcode/source/barcode/qr/util.d submodules/barcode/source/barcode/qrwrap.d submodules/barcode/source/barcode/svgdraw.d submodules/barcode/source/barcode/types.d submodules/barcode/source/barcode/util.d -preview=in -revert=dtorfields -preview=in -revert=dtorfields -vcolumns
Error: Output file '__dummy.html' for module `barcode.code39` collides with previous module `barcode.code128`. See the -oq option
FAIL submodules/barcode barcode staticLibrary

@kinke kinke changed the title [stable] LDC: Fix ddox options (output single dummy file, like DMD and GDC) [stable] LDC: Fix ddox regression (prevent colliding HTML output files) Jan 24, 2025
@kinke
Copy link
Contributor Author

kinke commented Jan 24, 2025

Okay, added the -oq option for ddox explicitly. The other compilers apparently don't check for HTML output file collisions.

@Geod24
Copy link
Member

Geod24 commented Jan 24, 2025

That did the trick, thanks!

@Geod24 Geod24 merged commit 4a69bd4 into dlang:stable Jan 24, 2025
19 of 31 checks passed
@kinke kinke deleted the ldc_ddox branch January 24, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants