Use Configy to read user settings (settings.json) too
#2343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geod24
changed the title
settings.json) too
Geod24
commented
Jul 28, 2022
Geod24
force-pushed
the
configy-user-setting
branch
2 times, most recently
from
093d064 to
21ae75f
Compare
|
Rebased, should be G2G, let's see what the CI says. |
This was referenced Jul 28, 2022
|
Hold on, there's one thing I forgot to tackle: Error handling. |
WebFreak001
requested changes
Jul 28, 2022
Geod24
force-pushed
the
configy-user-setting
branch
3 times, most recently
from
b8ff4e1 to
13c1d73
Compare
WebFreak001
reviewed
Jul 29, 2022
This will provide superior error messages to the user, and match what we already do for `dub.selections.json`. It also allows us to remove many fields from the `Dub` class. Those fields existed so that we would not have to re-compute the data from the JSON DubConfig was storing. Now that we use a simple struct, and do the aggregation eagerly, all of that complexity can go.
Geod24
force-pushed
the
configy-user-setting
branch
from
13c1d73 to
4169769
Compare
WebFreak001
reviewed
Jul 29, 2022
I actually tested it yesterday and the error handling LGTM. It's not colored but all the information is here. |
WebFreak001
approved these changes
Jul 29, 2022
This was referenced Aug 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2310First step towards #1832
Only the last two commits belong to this PR.
Once #2310 and this are merged, adding settings will be massively simpler.
I am thinking of holding back on #1832 so that we can come up with a "clean" format for the YAML settings, and it will make writing conversion code (from
settings.jsontosettings.yaml) much simpler.