Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: styles under dark mode #262

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DannySu09
Copy link

@DannySu09 DannySu09 commented Aug 9, 2023

Hi, just found 2 places that annoyed me under dark mode, therefore I made some fixes.

Remove the default style from browsers under dark mode

I found the color-scheme: dark/light on the HTML element will apply the default style from browsers.

As the image shows below, you can see a darker gray background behind the form region, comparing the lighter gray background of the user's site.

image

Fix the text color of the submit button

After removing the color-scheme: dark/light style on the HTML element, the text color of the submit button will still be white under dark mode. So I added a new class dark:text-gray-100 on the button to correct the text color.

@vercel
Copy link

vercel bot commented Aug 9, 2023

@sunaiwen is attempting to deploy a commit to the RandySoft Team on Vercel.

A member of the Team first needs to authorize it.

@kowyo
Copy link

kowyo commented Oct 23, 2023

It also annoys me. Thank you sunaiwen. Hope the owner could have a look at it @djyde

@dejalavidavolar
Copy link

Hi, just found 2 places that annoyed me under dark mode, therefore I made some fixes.

Remove the default style from browsers under dark mode

I found the color-scheme: dark/light on the HTML element will apply the default style from browsers.

As the image shows below, you can see a darker gray background behind the form region, comparing the lighter gray background of the user's site.

image

Fix the text color of the submit button

After removing the color-scheme: dark/light style on the HTML element, the text color of the submit button will still be white under dark mode. So I added a new class dark:text-gray-100 on the button to correct the text color.

Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants