RavenDB-22257 Making the transaction owner check on tx dispose to be …

…Debug only. Removing the usage of await in the scope of a write transaction in the test and making it sync. Added ConfigureAwait(true) to the transaction replay code to in order to try to get to the original thread (that opened the write tx) so the tests for the tx recorder won't fail in debug.

src/Raven.Server/Documents/ReplayTxCommandHelper.cs

@@ -44,7 +44,7 @@ internal static async IAsyncEnumerable<ReplayProgress> ReplayAsync(DocumentDatab
                 await using (var readersItr = readers.GetAsyncEnumerator())
                 {
                     await ReadStartRecordingDetailsAsync(readersItr, context, peepingTomStream);
-                    while (await readersItr.MoveNextAsync())
+                    while (await readersItr.MoveNextAsync().ConfigureAwait(true))
                     {
                         using (readersItr.Current)
                         {

src/Voron/Impl/LowLevelTransaction.cs

@@ -935,8 +935,7 @@ public void Dispose()
             if (_txState.HasFlag(TxState.Disposed))
                 return;
 
-            if (Flags == TransactionFlags.ReadWrite && NativeMemory.CurrentThreadStats != CurrentTransactionHolder)
-                ThrowDisposeOfTxMustBeCalledOnTheSameThreadThatCreatedIt();
+            EnsureDisposeOfWriteTxIsOnTheSameThreadThatCreatedIt();
 
             try
             {
@@ -1326,11 +1325,16 @@ private static void ThrowAlreadyCommitted()
             throw new InvalidOperationException("Cannot commit already committed transaction.");
         }
 
-        private void ThrowDisposeOfTxMustBeCalledOnTheSameThreadThatCreatedIt()
+        [Conditional("DEBUG")]
+        private void EnsureDisposeOfWriteTxIsOnTheSameThreadThatCreatedIt()
         {
-            throw new InvalidOperationException($"Dispose of the transaction must be called from the same thread that created it. " +
-                                                $"Transaction {Id} (Flags: {Flags}) was created by {CurrentTransactionHolder.Name}, thread Id: {CurrentTransactionHolder.ManagedThreadId}. " +
-                                                $"The dispose was called from {NativeMemory.CurrentThreadStats.Name}, thread Id: {NativeMemory.CurrentThreadStats.ManagedThreadId}");
+            if (Flags == TransactionFlags.ReadWrite && NativeMemory.CurrentThreadStats != CurrentTransactionHolder)
+            {
+                throw new InvalidOperationException($"Dispose of the write transaction must be called from the same thread that created it. " +
+                                                    $"Transaction {Id} (Flags: {Flags}) was created by {CurrentTransactionHolder.Name}, thread Id: {CurrentTransactionHolder.ManagedThreadId}. " +
+                                                    $"The dispose was called from {NativeMemory.CurrentThreadStats.Name}, thread Id: {NativeMemory.CurrentThreadStats.ManagedThreadId}. " +
+                                                    $"Do you have any await call in the scope of the write transaction?");
+            }
         }
 
         public void Rollback()

test/RachisTests/BasicTests.cs

@@ -2,6 +2,7 @@
 using System.Threading;
 using System.Threading.Tasks;
 using Raven.Client.ServerWide;
+using Raven.Client.Util;
 using Raven.Server.Rachis;
 using Raven.Server.ServerWide.Context;
 using Sparrow.Json;
@@ -59,10 +60,10 @@ await ActionWithLeader(async l =>
         }
 
         [Fact]
-        public async Task RavenDB_13659()
+        public void RavenDB_13659()
         {
-            var leader = await CreateNetworkAndGetLeader(1);
-            var mre = new AsyncManualResetEvent();
+            var leader = AsyncHelpers.RunSync(() => CreateNetworkAndGetLeader(1));
+            var mre = new ManualResetEventSlim();
             var tcs = new TaskCompletionSource<object>(TaskCreationOptions.RunContinuationsAsynchronously);
             var currentThread = NativeMemory.CurrentThreadStats.ManagedThreadId;
 
@@ -90,12 +91,12 @@ public async Task RavenDB_13659()
             using (leader.ContextPool.AllocateOperationContext(out ClusterOperationContext context))
             using (context.OpenWriteTransaction())
             {
-                await mre.WaitAsync();
+                mre.Wait();
                 leader.SetNewStateInTx(context, RachisState.Follower, null, leader.CurrentTerm, "deadlock");
                 context.Transaction.Commit();
             }
 
-            await tcs.Task;
+            AsyncHelpers.RunSync(() => tcs.Task);
         }
     }
 }

test/SlowTests/Voron/Issues/RavenDB_22257.cs

@@ -21,8 +21,11 @@ protected override void Configure(StorageEnvironmentOptions options)
 
         options.ManualFlushing = true;
     }
-
+#if DEBUG
     [RavenFact(RavenTestCategory.Voron)]
+#else
+    [RavenFact(RavenTestCategory.Voron, Skip = "This test relies on Debug only check - LowLevelTransaction.EnsureDisposeOfWriteTxIsOnTheSameThreadThatCreatedIt()")]
+#endif
     public void MustNotAllowToHaveTwoWriteTransactionsConcurrently()
     {
         RequireFileBasedPager();
@@ -48,7 +51,7 @@ public void MustNotAllowToHaveTwoWriteTransactionsConcurrently()
                     {
                         ex = Assert.Throws<InvalidOperationException>(() =>
                         {
-                            txw1.Dispose(); // this is supposed to throw because we're attempting to dispose write tx from a different thread
+                            txw1.Dispose(); // this is supposed to throw in Debug because we're attempting to dispose write tx from a different thread
 
                             txw2 = Env.NewLowLevelTransaction(new TransactionPersistentContext(), TransactionFlags.ReadWrite);
 
@@ -60,7 +63,7 @@ public void MustNotAllowToHaveTwoWriteTransactionsConcurrently()
 
                     newTransactionThread.Join();
 
-                    Assert.StartsWith("Dispose of the transaction must be called from the same thread that created it. Transaction 2 (Flags: ReadWrite) was created by", ex.Message);
+                    Assert.StartsWith("Dispose of the write transaction must be called from the same thread that created it. Transaction 2 (Flags: ReadWrite) was created by", ex.Message);
                 });
 
                 /*