Skip to content

Commit

Permalink
RavenDB-14706 Fix tests and lint errors
Browse files Browse the repository at this point in the history
  • Loading branch information
kalczur authored and ppekrol committed Nov 4, 2024
1 parent e61af4b commit 73ebcb4
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -23,18 +23,18 @@ describe("ConnectionStrings", () => {
const { screen } = await rtlRender_WithWaitForLoad(<DefaultConnectionStrings />);

expect(screen.queryByText(selectors.emptyList)).not.toBeInTheDocument();
expect(screen.queryAllByClassName("rich-panel-name")).toHaveLength(7);
expect(screen.queryAllByClassName("rich-panel-name")).toHaveLength(8);
});

it("can render action buttons when has access database admin", async () => {
const { screen } = await rtlRender_WithWaitForLoad(<DefaultConnectionStrings databaseAccess="DatabaseAdmin" />);

// one on the top + one per connection string
expect(screen.queryAllByRole("button", { name: selectors.addNew })).toHaveLength(8);
expect(screen.queryAllByRole("button", { name: selectors.addNew })).toHaveLength(9);

// one per connection string
expect(screen.queryAllByRole("button", { name: selectors.edit })).toHaveLength(7);
expect(screen.queryAllByRole("button", { name: selectors.delete })).toHaveLength(7);
expect(screen.queryAllByRole("button", { name: selectors.edit })).toHaveLength(8);
expect(screen.queryAllByRole("button", { name: selectors.delete })).toHaveLength(8);
});

it("can hide action buttons when has access below database admin", async () => {
Expand Down
1 change: 1 addition & 0 deletions src/Raven.Studio/typescript/components/utils/docsHashes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -95,4 +95,5 @@ export const docsHashes: Record<string, StringWithAutocomplete<"MISSING_DOCS">>
"admin/settings/debug/advanced/replayTransactionCommands": "MISSING_DOCS",
about: "MISSING_DOCS",
"databases/documents/revisions/all": "MISSING_DOCS",
"databases/tasks/editSnowflakeEtlTask": "MISSING_DOCS",
};
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
/// <reference path="../../../../typings/tsd.d.ts"/>
import genUtils = require("common/generalUtils");

class adminLogsOnDiskConfig {
selectedLogMode = ko.observable<TODO>();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ export function EditSnowflakeEtlInfoHub() {
</li>
<li>A connection string specifying the Snowflake storage destination,
<br/>
where "<i>Account</i>", "<i>Database</i>", and "<i>Schema</i>" are mandatory parameters.
where &quot;<i>Account</i>&quot;, &quot;<i>Database</i>&quot;, and &quot;<i>Schema</i>&quot; are mandatory parameters.
</li>
<li>A responsible node to handle this task can be set.</li>
</ul>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ import viewHelpers = require("common/helpers/view/viewHelpers");
import documentMetadata = require("models/database/documents/documentMetadata");
import getDocumentsMetadataByIDPrefixCommand = require("commands/database/documents/getDocumentsMetadataByIDPrefixCommand");
import getDocumentWithMetadataCommand = require("commands/database/documents/getDocumentWithMetadataCommand");
import popoverUtils = require("common/popoverUtils");
import { highlight, languages } from "prismjs";
import shardViewModelBase from "viewmodels/shardViewModelBase";
import licenseModel from "models/auth/licenseModel";
Expand Down

0 comments on commit 73ebcb4

Please sign in to comment.