Task/deseng602 Clean up unused code in the met-cron service (bcgov#2516)

* DESENG-602 Remove unneeded libraries and migrations * DESENG-602 Merge main and update changelog --------- Co-authored-by: Alex <[email protected]>
djnunez-aot · May 21, 2024 · 5563c53 · 5563c53
1 parent 8093fd2
commit 5563c53
Show file tree

Hide file tree

Showing 22 changed files with 14 additions and 770 deletions.
diff --git a/CHANGELOG.MD b/CHANGELOG.MD
@@ -1,3 +1,6 @@
+## May 21, 2024
+- **Task** Clean up met-cron [🎟️ DESENG-602](https://apps.itsm.gov.bc.ca/jira/browse/DESENG-602)
+
 ## May 16, 2024
 
 - **Bugfix** Replace Material Icons with Font Awesome [🎟️ DESENG-608](https://apps.itsm.gov.bc.ca/jira/browse/DESENG-608)

diff --git a/met-cron/Makefile b/met-cron/Makefile
@@ -138,9 +138,6 @@ run_publish: ## Run the publish task in local
 run_purge: ## Run the publish task in local
 	. venv/bin/activate && python invoke_jobs.py PURGE
 
-db: ## Update the local database
-	. venv/bin/activate && python manage.py db upgrade
-
 #################################################################################
 # Self Documenting Commands                                                     #
 #################################################################################

diff --git a/met-cron/README.md b/met-cron/README.md
@@ -29,10 +29,6 @@ Before running the following commands run `. venv/bin/activate` to enter into th
 >
 > Runs the application unit tests<br>
 
-> `make db`
->
-> Runs the application database migrations.
-
 > `make lint`
 >
 > Lints the application code.

diff --git a/met-cron/config.py b/met-cron/config.py
@@ -49,7 +49,6 @@ def get_named_config(environment: Union[str, None]) -> '_Config':
         'production': ProdConfig,
         'testing':    TestConfig,
         'docker':     DockerConfig,
-        'migration':  MigrationConfig,
     }
     try:
         print(f'Loading configuration: {environment}...')
@@ -232,16 +231,6 @@ def SQLALCHEMY_DATABASE_URI(self) -> str:
     # config for offset days to send reminder emails
     OFFSET_DAYS = os.getenv('OFFSET_DAYS', 2)
 
-class MigrationConfig():  # pylint: disable=too-few-public-methods
-    """Base class configuration that should set reasonable defaults for all the other configurations."""
-
-    # SQLAlchemy settings
-    # Echoes the SQL queries generated - useful for debugging
-    SQLALCHEMY_ECHO = env_truthy('SQLALCHEMY_ECHO', True)
-    # Disable modification tracking for performance
-    SQLALCHEMY_TRACK_MODIFICATIONS = env_truthy('SQLALCHEMY_TRACK_MODIFICATIONS', True)
-
-
 class DevConfig(_Config):  # pylint: disable=too-few-public-methods
     """Dev Config."""
 

diff --git a/met-cron/manage.py b/met-cron/manage.py
diff --git a/met-cron/migrations/README b/met-cron/migrations/README
diff --git a/met-cron/migrations/alembic.ini b/met-cron/migrations/alembic.ini
diff --git a/met-cron/migrations/env.py b/met-cron/migrations/env.py
diff --git a/met-cron/migrations/script.py.mako b/met-cron/migrations/script.py.mako
diff --git a/met-cron/migrations/versions/05e82fada6fe_add_runcycle_id_to_all_tables.py b/met-cron/migrations/versions/05e82fada6fe_add_runcycle_id_to_all_tables.py
diff --git a/met-cron/migrations/versions/07c0dcd415ea_etlruncycle.py b/met-cron/migrations/versions/07c0dcd415ea_etlruncycle.py
diff --git a/met-cron/migrations/versions/b2ee16c80e7c_combine_radio_and_selectbox.py b/met-cron/migrations/versions/b2ee16c80e7c_combine_radio_and_selectbox.py