-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prio3: Add support for multiple proofs #850
Conversation
618e840
to
bb975ce
Compare
bb975ce
to
ea0286d
Compare
I'll rebase on top of #851. |
ea0286d
to
11b6111
Compare
Rebased! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I checked benchmark performance, and all differences were within the noise threshold, so no worries there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
FYI, I was working through re-enabling Prio3 test vectors, and I noticed that the Prio3SumVecWithMultiproof_0.json file was generated using an algorithm ID of 0xFFFFFFFF. That may or may not be an oversight in the spec, but note that this implementation keeps using the same Prio3SumVec algorithm ID passed through from the SumVec Type impl. (We don't need to block merging this PR for this issue, and can fix the algorithm ID or test vector file in a followup) |
We didn't intend to allocate codepoints for these, so the algorithm ID is fine. In fact, generating test vectors for these was an oversight on my part (cfrg/draft-irtf-cfrg-vdaf#315). I suggest we remove them. |
As of draft-irtf-cfrg-vdaf-08 it's possible to configure to Prio3 so that the Client generates (and the Aggregators verify) multiple FLPs for the same measurement. This commit adds support for this feature. While at it, this commit de-duplicates some of the code used to derive field elements from seeds.
c9c4f46
to
1d95adf
Compare
Rebased and squashed. |
Partially addresses #839.
Stacked on #851.
As of draft-irtf-cfrg-vdaf-08 it's possible to configure to Prio3 so that the Client generates (and the Aggregators verify) multiple FLPs for the same measurement. This commit adds support for this feature. While at it, this commit de-duplicates some of the code used to derive field elements from seeds.