mastic: Use empty seeds instead of zero seeds #1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjpatton
force-pushed
the
cjpatton/947-10-dst-alg-id
branch
from
442c6c2 to
51fef8b
Compare
cjpatton
force-pushed
the
cjpatton/947-11-empty-seeds
branch
from
1a8cf4f to
5614384
Compare
|
Rebased on main. |
divergentdave
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #1195.
Partially addresses #947.
See jimouris/draft-mouris-cfrg-mastic#106.
To allow using empty seeds, we hardcode the XOF to
XofTurboShake128. We also considered API changes to accommodate different instantiations of the XOF, but opted to hardcode in order to nudge users towards the standardized variant. Note that this also means that Mastic requires the "crypto-dependencies" feature.