mastic: Align XOF computations with the spec #1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjpatton
commented
Dec 31, 2024
cjpatton
commented
Dec 31, 2024
cjpatton
commented
Dec 31, 2024
cjpatton
commented
Dec 31, 2024
cjpatton
commented
Dec 31, 2024
cjpatton
commented
Dec 31, 2024
divergentdave
approved these changes
Jan 2, 2025
cjpatton
force-pushed
the
cjpatton/947-3
branch
from
1dcf6ea to
eb8a6e3
Compare
cjpatton
force-pushed
the
cjpatton/947-4
branch
from
72218d4 to
d2f16c6
Compare
|
Rebased. |
cjpatton
force-pushed
the
cjpatton/947-4
branch
from
d2f16c6 to
8019b71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #1181.
Partially addresses #947.
The last step is to add the test vectors and fix any bugs they catch. Note that we need to make a few minor adjustments to the Mastic spec and regenerate test vectors.