Combined helper measurement and helper proof seeds #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
divergentdave
approved these changes
Jan 2, 2025
|
Looks like un-ignoring might be nontrivial. Wanna land this and I'll start another PR? |
|
Sure sounds good. I think the remaining failure will be fixed by #1170. |
|
Actually nvm I got it all working |
divergentdave
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before draft 12, the Prio3 sharding algorithm used different PRG seeds for the non-leader measurement share and the non-leader proof share. Since draft 12 (spec diff), these shares are generated from the same seed (with different domain separators). This PR updates the Prio3 sharding algorithm, and also has a few cleanups.
Closes a subtask of #1122.