Added max_measurement field to Prio3Sum type
#1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
FYI, I think this'll need to be rebased to pick up some Clippy lint fixes.
The other methods in the Type implementation look good. Most of these get checked by the FLP unit tests or valid_call_check(), etc., but maybe not all. I checked them against the definitions in the spec, with formulas using gadget calls, gadget arities, etc.
19 tasks
divergentdave
approved these changes
Dec 9, 2024
cjpatton
pushed a commit
that referenced
this pull request
Dec 12, 2024
cjpatton
pushed a commit
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old
Prio3Sumlet summands anything <2^bits. In newer drafts, the type now has amax_measurementparameter that can constrain the size of summands. Closes a subtask of #1122.Some open questions:
input_len(),proof_len(), andeval_output_len()correctly, but what about the other methods? Would I know via unit tests if they were wrong?input_len()to find out the correct measurement size to use. Is that an acceptable API for Mastic? I'm not familiar, so this might be fine.