Addressed comments

divviup · Jan 6, 2025 · 606c72a · 606c72a
1 parent 8fcbbe8
commit 606c72a
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/vdaf/prio3.rs b/src/vdaf/prio3.rs
@@ -1039,6 +1039,8 @@ where
             let measurement_len = T::Field::ENCODED_SIZE * prio3.typ.input_len();
             let proof_len = T::Field::ENCODED_SIZE * prio3.typ.proof_len() * prio3.num_proofs();
 
+            // TODO optimization: Use a decoding routine that preallocates using knowledge of the
+            // expected output len
             let measurement_share = decode_items(measurement_len, &(), bytes)?;
             let proofs_share = decode_items(proof_len, &(), bytes)?;
 
@@ -1464,7 +1466,7 @@ where
 
         Ok((
             Prio3PrepareState {
-                measurement_share: msg.measurement_share().clone(),
+                measurement_share: msg.measurement_share(),
                 joint_rand_seed,
                 agg_id,
                 verifiers_len: verifiers_share.len(),