Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a single-file browser build #536

Merged
merged 2 commits into from
Nov 21, 2023
Merged

add a single-file browser build #536

merged 2 commits into from
Nov 21, 2023

Conversation

jbr
Copy link
Contributor

@jbr jbr commented Nov 20, 2023 •
edited
Loading

closes #407

when this is published, we will be able to provide standalone examples like this:

<html>
  <body>
    <script src="https://unpkg.com/@divviup/dap/dist/browser.js"></script>
    <script>
      new divviup.dap.Task({
        type: "count",
        id: "...",
        leader: "https://xxx.api.divviup.org/",
        helper: "https://yyy.api.divviup.org/",
        timePrecisionSeconds: 3600
      }).sendMeasurement(true);
    </script>
  </body>
</html>

@jbr jbr requested a review from a team as a code owner November 20, 2023 23:56
@jbr jbr force-pushed the add-script-bundled-build branch from 0c56e70 to cca80b0 Compare November 20, 2023 23:57
@coveralls
Copy link

coveralls commented Nov 20, 2023 •
edited by github-actions bot
Loading

Pull Request Test Coverage Report for Build 6948041012

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.09%) to 84.739%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/dap/src/browser.ts 0 4 0.0%
Totals Coverage Status
Change from base Build 6948024529: -0.09%
Covered Lines: 3418
Relevant Lines: 4046
💛 - Coveralls

@jbr jbr force-pushed the add-script-bundled-build branch from ae3e2d7 to 1ea0eb4 Compare November 21, 2023 18:25
divergentdave
divergentdave approved these changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@divergentdave divergentdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this in Firefox against staging, and it worked. The source map looks good too.

@jbr jbr merged commit cef939d into main Nov 21, 2023
5 checks passed
@jbr jbr deleted the add-script-bundled-build branch November 21, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divergentdave divergentdave divergentdave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Produce a bundled script for direct use in web browsers
3 participants
@jbr @coveralls @divergentdave