Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update readme for demo notebooks and updates to cite_sorcha() #744

Merged
merged 4 commits into from
Dec 13, 2023

Conversation

mschwamb
Copy link
Collaborator

@mschwamb mschwamb commented Dec 11, 2023

clean up demo notebooks readme and give all the notebooks consistent naming

Fixes #720

I've also run a few of the notebooks that didn't have plots generated. My thinking is that we want them actually run so people can look at the repo and see the results. It's not 21 Mb which is tiny. I also changed the testing of the circle footprint to also plot the before so you can see that a smaller circle of detections has been selected.

Fixes #732

update cite_sorcha to remove all the pytest warnings about the single slashes in print statements. I also put all the citations for each of the packages in alphabetical order by package name

clean up demo notebooks readme and give all the notebooks consistent naming
renaming notebooks for consistency
renaming notebooks for consistency
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (09f6339) 65.31% compared to head (c35fdbd) 65.28%.
Report is 1 commits behind head on main.

❗ Current head c35fdbd differs from pull request most recent head bde75d9. Consider uploading reports for the commit bde75d9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #744      +/-   ##
==========================================
- Coverage   65.31%   65.28%   -0.04%     
==========================================
  Files          67       67              
  Lines        3451     3448       -3     
==========================================
- Hits         2254     2251       -3     
  Misses       1197     1197              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fixed pytest errors and made the entries alphabetical
@mschwamb mschwamb changed the title update readme for demo notebooks update readme for demo notebooks and updates to cite_sorcha() Dec 12, 2023
@mschwamb mschwamb merged commit f302e00 into main Dec 13, 2023
7 of 8 checks passed
@mschwamb mschwamb deleted the notebook_updates branch December 15, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix warnings in citation function Update README.md in notebooks directory
2 participants