Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #737. #742

Merged
Merged

Conversation

astronomerritt
Copy link
Contributor

Fixes #737.

Moved the FOV filters to be applied only after randomising astrometry and updated the goldens.

Review Checklist for Source Code Changes

  • Does pip install still work?
  • Have you written a unit test for any new functions?
  • Do all the units tests run successfully?
  • Does Sorcha run successfully on a test set of input files/databases?
  • Have you used black on the files you have updated to confirm python programming style guide enforcement?

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aa86227) 65.31% compared to head (bcbae58) 65.28%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #742      +/-   ##
==========================================
- Coverage   65.31%   65.28%   -0.04%     
==========================================
  Files          67       67              
  Lines        3451     3448       -3     
==========================================
- Hits         2254     2251       -3     
  Misses       1197     1197              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@astronomerritt astronomerritt merged commit 443fcf7 into dirac-institute:main Dec 11, 2023
8 of 10 checks passed
@astronomerritt astronomerritt deleted the moving_FOV_filter branch January 10, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

only do footprint filter after randomizing astrometry
2 participants