Minor clean up issues related to including the config file data classes #1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed some commented out lines, removed unused functions and their unit tests in PPConfigParser.py, made sure all config variables are outputted to log and a unit test has been made for function PrintConfigsToLog.
mschwamb
requested changes
Jan 8, 2025
src/sorcha/modules/PPConfigParser.py
Outdated
There was a problem hiding this comment.
I think it's confusing to keep a file that's called PPConfigParser with just these functions in them - either we should rename this so it's a file utility or something but ebing PPConfigParser is probably not informative or helpful in the long term for maintenance.
There was a problem hiding this comment.
What about shoving this into utilities folder with a different name?
Removed PPConfigParser and moved the two functions in it into a new file called Find_File_or_Directory.py in the utilities folder. Also moved the unit tests for these functions into test_Find_File_or_Directory.py
Changed name of Find_File_or_Directory to fileAccessUtils. Unit tests have been manually ran on my computer and they passed.
|
Looks good to me. |
mschwamb
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1081 .
Removed some commented out lines, removed unused functions and their unit tests in PPConfigParser.py, made sure all config variables are outputted to log and a unit test has been made for function PrintConfigsToLog.
Review Checklist for Source Code Changes