Have KBMOD append RA, dec columns if possible #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremykubica
changed the title
maxwest-uw
approved these changes
Jan 11, 2025
There was a problem hiding this comment.
this all looks good! the only issue that I can think of is that if the WorkUnit was reprojected with a common WCS that wasn't in EBD it could cause it to return some weirdness when using the image_positions_to_original_icrs function, but I don't think we need to cover that scope fully in this pr since that's not a typical use pattern afaik
|
Thanks @maxwest-uw . Long term, I think we will want to support non-EBD reprojections. I created Issue #772 and assigned it to you. I'm happy to discuss what is needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we provide KBMOD a
WorkUnitwith wcs values, append the EBD (RA, dec) and the original (RA, dec) where possible.