Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expands StackSearch to support single searches #458

Merged
merged 7 commits into from
Feb 8, 2024

Conversation

jeremykubica
Copy link
Contributor

@jeremykubica jeremykubica commented Feb 6, 2024

This is step 3 of N in addressing #447.

Expands the StackSearch class to support single searches. In addition, this cleans up data management within StackSearch:

  • The combined PsiPhiArray is maintained and used for all processing in place of the individual vectors of RawImage, providing a single consistent data source for all functions. The major change here is extracting the psi and phi curves from the PsiPhiArray instead of the individual images.
  • Setters for min_obs and min_lh are added to StackSearch
  • Additional null pointer checking is added to functions for safety.
  • The helper function make_trajectory is used instead of manual Trajectory creation in tests.
  • Add a bunch of validity checks for the parameter settings functions.
  • Add some doc strings.

Passes all tests and the diff test on some old DEEP data.

@jeremykubica jeremykubica merged commit ee1edf4 into main Feb 8, 2024
2 checks passed
@jeremykubica jeremykubica deleted the stack_search_single branch February 8, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants