Transition to pyproject.toml and enable automatic module detection. #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DinoBektesevic
force-pushed
the
buildsys/autodetect
branch
from
355b393 to
66e420f
Compare
jeremykubica
approved these changes
Jan 29, 2024
This gets rid of the old setup.cfg and enables module autodetect to work - so we don't have to keep listing them inthe setup.cfg.
DinoBektesevic
force-pushed
the
buildsys/autodetect
branch
from
66e420f to
5dce625
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "downside" to this approach is that the environment-wide installation will also copy over all the source code files from C++ making it marginally larger. I'm ok with that, since this already happens anyhow. I think I like this more than the proposal for build system restructuring in the draft proposal #434
Blocked by #334.