Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A series of small cleanups for KBMOD #431

Merged
merged 6 commits into from
Jan 12, 2024
Merged

A series of small cleanups for KBMOD #431

merged 6 commits into from
Jan 12, 2024

Conversation

jeremykubica
Copy link
Contributor

  • Removes a redundant contains check in LayeredImage pixel lookup.
  • Adds some additional checks during the computation of Psi and Phi images
  • Adds doc strings for the computation of Psi and Phi images
  • Adds a bunch of psi and phi tests
  • Mechanical application of clang-format

@jeremykubica jeremykubica requested a review from wilsonbb January 12, 2024 15:40
wilsonbb
wilsonbb approved these changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@wilsonbb wilsonbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few typos :)

tests/test_layered_image.py Outdated Show resolved Hide resolved
src/kbmod/search/pydocs/layered_image_docs.h Outdated Show resolved Hide resolved
@jeremykubica jeremykubica merged commit 1e6746d into main Jan 12, 2024
2 checks passed
@jeremykubica jeremykubica deleted the cleanups branch January 12, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilsonbb wilsonbb wilsonbb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremykubica @wilsonbb