stamp center filter c++ port #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous Benchmarks(recorded 10/12/2023) New Benchmark(recorded 12/19/2023) |
| @@ -30,7 +39,7 @@ def setup_coadd_stamp(params): | |||
| p = PSF(1.0) | |||
| psf_dim = p.get_dim() | |||
| psf_rad = p.get_radius() | |||
| for i in range(psf_dim): | |||
| for i in range(1, psf_dim): | |||
There was a problem hiding this comment.
I'm not sure why this is changing. The calculation below moves the center pixel one off, but shouldn't the convolution with the PSF still cover the full PSF?
There was a problem hiding this comment.
before the range of the outer for loop would include -1 when i is 0 (due to the one pixel offset), giving an out of bound error. I just changed the range to only include dimensions that fall within the PSF.
| @@ -103,7 +103,7 @@ def keep_row(self, row: ResultRow): | |||
| return False | |||
|
|
|||
| # Find the peak in the image. | |||
| stamp = row.stamp.reshape([self.width, self.width]) | |||
| stamp = row.stamp | |||
There was a problem hiding this comment.
Is this change because stamp is already in the correct shape? Or is there some other reason?
jeremykubica
approved these changes
Dec 20, 2023
Closed
DinoBektesevic
pushed a commit
that referenced
this pull request
Jan 10, 2024
* porting over first pass * merge * fix bug in array size check * remove commented out code * black changes * fix benchmarking script * code reorganization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ports the code for the stamp center filter into c++.