Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Up Configuration #405

Merged
merged 6 commits into from
Dec 15, 2023
Merged

Clean Up Configuration #405

merged 6 commits into from
Dec 15, 2023

Conversation

jeremykubica
Copy link
Contributor

With PR #403 we moved from a per-image, per-vector encoding to a single encoding size for both psi and phi vectors. This allows us to simplify some of the configuration and interfaces. Specifically:

  • Replace configuration parameters encode_phi_bytes and encode_psi_bytes with encode_num_bytes.
  • Remove structs scaleParameters and PerImageData.
  • Replace uses of PerImageData with a vector of times (the only data it still needs to carry around).

This PR also applies clang format to files that have changed recently and combines multiple tests in test_search_encode.py using unittest's subTest functionality.

@jeremykubica jeremykubica merged commit 66165d5 into main Dec 15, 2023
2 checks passed
@jeremykubica jeremykubica deleted the cleanup branch December 15, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants