-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add options to output result data #395
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a typo and an optional suggestion
row = ResultRow(trj, self.num_times) | ||
row.set_psi_phi(np.array([i] * self.num_times), np.array([0.01 * i] * self.num_times)) | ||
row.stamp = np.ones((10, 10)) | ||
row.all_stamps = np.array([np.ones((10, 10)) for _ in range(self.num_times)]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional: np.full
can take an ndarray, so might be cleaner to have
row.stamp = np.ones((10, 10))
row.all_stamps = np.full((self.num_times, 10, 10), row.stamp)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preemptive approval since the requested change is just a typo
Allow users to output options in a two different formats:
This PR also moves some of the trajectory serialization into its own file for organizational purposes.