perf: simplify req.accepts*

[nigrosimone]

• No need to declare a new variable const accept = accepts({ headers: this.headers }); e8bb956
• No need to create a object accepts({ headers: this.headers }) 6ff51e6

Bonus Improvements:

• Maybe we can also cache accepts(this) initialization, see perf: simplify req.accepts* #56 (comment)

[pkg-pr-new]

Open in Stackblitz

npm i https://pkg.pr.new/dimdenGD/ultimate-express@56

commit: 6ff51e6

[nigrosimone]

@dimdenGD Maybe we can also cache accepts(this) initialization, eg: ?

 accepts(...types) {
    if (!this.#accepts) {
      this.#accepts = accepts(this);
    }
    return this.#accepts.types(...types);
  }

  acceptsCharsets(...charsets) {
    if (!this.#accepts) {
      this.#accepts = accepts(this);
    }
    return this.#accepts.charsets(...charsets);
  }

  acceptsEncodings(...encodings) {
    if (!this.#accepts) {
      this.#accepts = accepts(this);
    }
    return this.#accepts.encodings(...encodings);
  }

  acceptsLanguages(...languages) {
    if (!this.#accepts) {
      this.#accepts = accepts(this);
    }
    return this.#accepts.languages(...languages);
  }

[dimdenGD]

Probably no point in caching because calling that function just creates a class with no real work done until function is called