Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix styling of page preview #3396

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Conversation

MizukiTemma
Copy link
Member

Short description

This PR fixes the styling of page preview.

Proposed changes

  • Add a new css for page preview

Side effects

  • None?

Resolved issues

Fixes: #3072


Pull Request Review Guidelines

@charludo
Copy link
Contributor

charludo commented Feb 5, 2025

Can you recommend a page to test this on? 🙈 Both for the page Svenja linked in the issue and the pages I've tried in my local CMS environment, previews were already working in both FF and Chromium, so I am a bit confused 🙈

Not doubting the issue exists, just unsure how to test! ^^

@MizukiTemma
Copy link
Member Author

@charludo
I have copied the source code of the referenced page, pasted it in the local environment and tried the preview with Chrome.

@JoeyStk JoeyStk self-requested a review February 5, 2025 14:06
@JoeyStk JoeyStk self-assigned this Feb 5, 2025
Copy link
Contributor

@JoeyStk JoeyStk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!
I was able to reproduce this issue in both FF and Chromium, and it works for me with this PR :)

@charludo
Copy link
Contributor

charludo commented Feb 6, 2025

Thank you very much! I was able to reproduce this issue in both FF and Chromium, and it works for me with this PR :)

Strange! I am still unable to reproduce it, in any browser, and both in the dev environment and the test-cms.

image

Left is the page Svenja linked, right is the copy-pasted source code of that page in my local env on your branch. Already tried force-refreshing and deleting cache.

Anyways, since this apparently does its purpose for those thatare affected, and I can notice no negative impact, I'll simply approve 😄

@MizukiTemma
Copy link
Member Author

@charludo
No negative efffect is also nice :)

@MizukiTemma MizukiTemma force-pushed the fix/page_preview_styling branch from 75c0418 to 843810e Compare February 6, 2025 14:45
@MizukiTemma MizukiTemma merged commit d220c8a into develop Feb 6, 2025
5 checks passed
@MizukiTemma MizukiTemma deleted the fix/page_preview_styling branch February 6, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preview styling for pages is broken
3 participants