Reformat phone numbers in the contact form #3386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charludo
requested review from
JoeyStk,
MizukiTemma,
jonbulz and
jarlhengstmengel
charludo
force-pushed
the
fix/reformat-contact-phone-numbers
branch
from
fd406a6 to
701dba4
Compare
MizukiTemma
approved these changes
Feb 4, 2025
charludo
force-pushed
the
fix/reformat-contact-phone-numbers
branch
from
701dba4 to
aced56f
Compare
JoeyStk
approved these changes
Feb 5, 2025
charludo
force-pushed
the
fix/reformat-contact-phone-numbers
branch
from
aced56f to
0c490a8
Compare
JoeyStk
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Phone numbers should be reformatted in the contact form, analogously to how they are currently being reformatted after entering them in TinyMCE. This PR replicates the tinymce-based logic in a custom
cleanmethod on theContactForm.Proposed changes
Side effects
Resolved issues
Fixes: #3383
Pull Request Review Guidelines