Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contact cards details editing #3376

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

charludo
Copy link
Contributor

Short description

Currently, changing the details shown on a contact card is broken. This is due to a mistake made rebasing #3320 onto develop after the merging of #3305.

Proposed changes

Side effects

  • none

Resolved issues

Fixes: n/a


Pull Request Review Guidelines

@charludo charludo added effort: low Should be doable in <4h deadline Needs to be fixed in the given time labels Jan 29, 2025
@osmers
Copy link

osmers commented Jan 30, 2025

Correct me, if I'm wrong - but now I cannot select which contact details should be shown at all anymore. However, I get back to the view with my current contact selected when clicking on "change contact". @charludo

@charludo
Copy link
Contributor Author

Correct me, if I'm wrong - but now I cannot select which contact details should be shown at all anymore. However, I get back to the view with my current contact selected when clicking on "change contact". @charludo

On this branch? That is very weird.

@JoeyStk JoeyStk self-assigned this Jan 30, 2025
@charludo
Copy link
Contributor Author

charludo commented Jan 31, 2025

@osmers on this branch, selecting/editing details definitely works. However, you are right in that this does not work on the current test cms. The reason is simply that the HIX-branch is behind compared to the develop branche's state, so the "new" testing package currently live in the test cms is older than the previous version in some respects.

This should not hinder tetsing the impact of the contact cards on HIX scores though.

Edit: now that #3375 is merged, I've updated this branch, so once that dev package is live, it should both work again. Keep in mind that the fix for editing the details after insertion is not merged yet though!

@osmers
Copy link

osmers commented Jan 31, 2025

Alright :) then I will test the HIX score @charludo
I just thought I should test the selection for contact details since this is the issue we are currently in :D

@charludo
Copy link
Contributor Author

Alright :) then I will test the HIX score @charludo I just thought I should test the selection for contact details since this is the issue we are currently in :D

Oh, OK! Yeah, sorry for the confusion.

@charludo charludo force-pushed the fix/contact-card-details-updates branch from 5e6e7ad to 602d611 Compare February 5, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deadline Needs to be fixed in the given time effort: low Should be doable in <4h
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants