set vc.issuer appropriately #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that we're doing this to satisfy the VC API test suite, which uses a test VC whose issuer is set to a string value rather than an object. |
dmitrizagidulin
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the incoming VC (to be signed) already has the top level issuer property set as a string value, then set that value to the did used to sign the VC. Set the value even if the existing value was different (i.e., overwrite the value).
If the incoming VC has a top level issuer property set to an object then set the 'id' property on that object with the did used to the sign the VC. Again, overwrite the id even if it is different from the signing did.
If the incoming VC has no issuer property or no value set for the issuer property then set the issuer property to be an object with an id property whose value is the signing DID.