Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting #17

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Linting #17

merged 1 commit into from
Nov 1, 2023

Conversation

stuartf
Copy link
Contributor

@stuartf stuartf commented Aug 24, 2023

This should:

  • setup linting to match the isomorphic-lib-template
  • get all code into compliance
  • make a pre-commit hook to:
    • check any staged files for lint errors
    • run all unit tests

Copy link
Member

@dmitrizagidulin dmitrizagidulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks for doing this, @stuartf !

@sembrat
Copy link

sembrat commented Oct 3, 2023

@dmitrizagidulin how would you like us to continue with this? Would you like us to rebase and commit, or is that something the DCC would like to lead on?

@jchartrand
Copy link
Contributor

jchartrand commented Oct 24, 2023

@stuartf Hey Stuart, did you want to merge it in to main? I mean: did you want to merge it in yourself?

@stuartf
Copy link
Contributor Author

stuartf commented Oct 27, 2023

@jchartrand sure, I can merge this myself, I just didn't want to step on any toes if that wasn't the way you expected it to happen.

@jchartrand
Copy link
Contributor

@stuartf Is it okay with you if I squash the 5 commits and then merge?

@stuartf
Copy link
Contributor Author

stuartf commented Oct 31, 2023

@jchartrand yes, I'm fine with you squashing the commits and merging, go for it

@jchartrand jchartrand merged commit 0f790ea into main Nov 1, 2023
1 check passed
@stuartf stuartf deleted the linting branch November 1, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants