Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct minor error with parameter required error in derive. #178

Merged
merged 4 commits into from
May 17, 2024

Conversation

aljones15
Copy link
Contributor

No description provided.

@aljones15 aljones15 requested review from dlongley and BigBlueHat May 17, 2024 14:58
@aljones15 aljones15 self-assigned this May 17, 2024
@aljones15 aljones15 requested a review from davidlehn May 17, 2024 14:58
Copy link
Member

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See suggestion. Also, we might want to target this at another branch to avoid a big rebase operation.

lib/index.js Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented May 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 88.66%. Comparing base (f7cf40c) to head (4a7cc42).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #178      +/-   ##
==========================================
- Coverage   88.77%   88.66%   -0.11%     
==========================================
  Files           4        4              
  Lines         811      812       +1     
==========================================
  Hits          720      720              
- Misses         91       92       +1     
Files Coverage Δ
lib/index.js 89.06% <0.00%> (-0.13%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7cf40c...4a7cc42. Read the comment docs.

@aljones15 aljones15 merged commit b151dc3 into main May 17, 2024
5 checks passed
@aljones15 aljones15 deleted the correct-parameter-name branch May 17, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants