-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VC 2.0 Add test for VPs with mixed context VCs. #171
Conversation
77a7d23
to
e6a3d3d
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## update-vc-2.0 #171 +/- ##
================================================
Coverage ? 89.43%
================================================
Files ? 5
Lines ? 994
Branches ? 0
================================================
Hits ? 889
Misses ? 105
Partials ? 0 Continue to review full report in Codecov by Sentry.
|
9ff44fe
to
4f59e13
Compare
eb376fe
to
600f75e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't look at this line-by-line, but support getting a VP 2.0 test in here that contains VCs with different versions.
This adds a test for VPs with VCs that use both the VC 1.0 and 2.0 context.
2.0 VPs should be able to contain mixed version/context VCs.
This PR also improves the language of the test titles including the count in each test title.
An issue with further details is here: #169