Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VC 2.0 Add test for VPs with mixed context VCs. #171

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

aljones15
Copy link
Contributor

@aljones15 aljones15 commented Jan 11, 2024

This adds a test for VPs with VCs that use both the VC 1.0 and 2.0 context.
2.0 VPs should be able to contain mixed version/context VCs.
This PR also improves the language of the test titles including the count in each test title.

An issue with further details is here: #169

@aljones15 aljones15 changed the title Add test for VPs with mixed context VCs. VC 2.0 Add test for VPs with mixed context VCs. Jan 11, 2024
@aljones15 aljones15 requested a review from BigBlueHat January 11, 2024 15:58
test/mocks/mock.data.js Show resolved Hide resolved
@BigBlueHat BigBlueHat self-requested a review February 5, 2024 14:03
@aljones15 aljones15 force-pushed the add-mixed-vc-context-tests-VC-2.0 branch from 77a7d23 to e6a3d3d Compare February 5, 2024 18:03
@aljones15 aljones15 self-assigned this Feb 5, 2024
@aljones15 aljones15 marked this pull request as ready for review February 5, 2024 18:25
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (update-vc-2.0@9ff44fe). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             update-vc-2.0     #171   +/-   ##
================================================
  Coverage                 ?   89.43%           
================================================
  Files                    ?        5           
  Lines                    ?      994           
  Branches                 ?        0           
================================================
  Hits                     ?      889           
  Misses                   ?      105           
  Partials                 ?        0           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ff44fe...eb376fe. Read the comment docs.

@aljones15 aljones15 force-pushed the add-mixed-vc-context-tests-VC-2.0 branch from eb376fe to 600f75e Compare April 26, 2024 14:41
Copy link
Member

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't look at this line-by-line, but support getting a VP 2.0 test in here that contains VCs with different versions.

@aljones15 aljones15 merged commit 99c1bbf into update-vc-2.0 Apr 29, 2024
8 of 10 checks passed
@aljones15 aljones15 deleted the add-mixed-vc-context-tests-VC-2.0 branch April 29, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants