DR2-2002 Validate metadata only #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows you to skip the file exists, checksum and integrity checks which you may need if you have a draft metadata file without the files themselves. I've added a button in the UI, an argument in the CLI and an option in the Java bridge.
sparkhi
reviewed
Nov 22, 2024
| } | ||
| )) | ||
| btnValidate.reactions += validateOnClick(btnValidate, false) | ||
| btnValidateMetadataOnly.reactions += validateOnClick(btnValidate, true) |
There was a problem hiding this comment.
I think you need to pass the btnValidateMetadataOnly in this reaction, otherwise it might enable / disable wrong button. Also, if the processing is taking long, I am wondering whether we should disable both buttons?
There was a problem hiding this comment.
Ah good spot, thanks.
sparkhi
reviewed
Nov 22, 2024
sparkhi
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to skip the file exists, checksum and integrity checks
which you may need if you have a draft metadata file without the files
themselves.
I've added a button in the UI, an argument in the CLI and an option in
the Java bridge.