Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify typecast of zero-extension to just a typecast #8586

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

tautschnig
Copy link
Collaborator

The intervening zero-extension does not alter the semantics and hinders the application of skip_typecast.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link

codecov bot commented Feb 9, 2025

Codecov Report

Attention: Patch coverage is 32.43243% with 25 lines in your changes missing coverage. Please review.

Project coverage is 78.48%. Comparing base (66004dc) to head (b5562a7).

Files with missing lines Patch % Lines
src/util/simplify_expr.cpp 32.43% 25 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8586      +/-   ##
===========================================
- Coverage    78.71%   78.48%   -0.23%     
===========================================
  Files         1732     1732              
  Lines       199536   200129     +593     
  Branches     18281    18248      -33     
===========================================
+ Hits        157057   157069      +12     
- Misses       42479    43060     +581     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kroening
Copy link
Member

kroening commented Feb 9, 2025

Sure this is sound as is?
E.g., an enlarging cast to a signed type would yield a different result if done before vs. after the zero extension.

The intervening zero-extension hinders the application of
`skip_typecast`.
@tautschnig
Copy link
Collaborator Author

Sure this is sound as is? E.g., an enlarging cast to a signed type would yield a different result if done before vs. after the zero extension.

Thank you, you are of course right. I have reworked the change to address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants