-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update third-party miniz to 0c30a001bc3c70 #8563
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8563 +/- ##
===========================================
+ Coverage 78.95% 79.43% +0.47%
===========================================
Files 1730 1730
Lines 198759 197598 -1161
Branches 18314 17932 -382
===========================================
+ Hits 156938 156958 +20
+ Misses 41821 40640 -1181 ☔ View full report in Codecov by Sentry. |
36eac0c
to
a645a06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm taking the first commit is the noted miniz code on faith (I've not manually checked it).
This version 3.0.2 of miniz plus all the changes up to and incluing the fix for CVE-2018-12913.
We were already ignoring miniz.cpp (since 0ebe5f4).
This is third-party code.
We only need inflate, no need for deflate or Zlib compatibility.
No need for static functions that are only used when `MINIZ_NO_ARCHIVE_WRITING_APIS` is unset.
a645a06
to
35bf91a
Compare
This version 3.0.2 of miniz plus all the changes up to and incluing the fix for CVE-2018-12913.