Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update third-party miniz to 0c30a001bc3c70 #8563

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

tautschnig
Copy link
Collaborator

This version 3.0.2 of miniz plus all the changes up to and incluing the fix for CVE-2018-12913.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.43%. Comparing base (07cf0bb) to head (35bf91a).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8563      +/-   ##
===========================================
+ Coverage    78.95%   79.43%   +0.47%     
===========================================
  Files         1730     1730              
  Lines       198759   197598    -1161     
  Branches     18314    17932     -382     
===========================================
+ Hits        156938   156958      +20     
+ Misses       41821    40640    -1181     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tautschnig tautschnig marked this pull request as ready for review January 13, 2025 14:43
Copy link
Contributor

@TGWDB TGWDB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm taking the first commit is the noted miniz code on faith (I've not manually checked it).

This version 3.0.2 of miniz plus all the changes up to and incluing the
fix for CVE-2018-12913.
We were already ignoring miniz.cpp (since 0ebe5f4).
This is third-party code.
We only need inflate, no need for deflate or Zlib compatibility.
No need for static functions that are only used when
`MINIZ_NO_ARCHIVE_WRITING_APIS` is unset.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants