Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless steps from Rust CI pipeline #8030

Merged

Conversation

esteffin
Copy link
Contributor

Removed 3 useless steps from the CBMC Rust:

  1. now we build only the required cprover-api-cpp target and its transitive dependencies excluding all binaries not needed, unit tests and JBMC.
  2. we add -DWITH_JBMC=OFF to the cmake arguments removing the configuration steps for it.
  3. we removed the installation of maven used only when building JBMC that is now not happening.
  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Removed 3 useless steps from the CBMC Rust:
1. now we build only the required `cprover-api-cpp` target and its
   transitive dependencies excluding all binaries not needed, unit
   tests and JBMC.
2. we add `-DWITH_JBMC=OFF` to the cmake arguments removing the
   configuration steps for it.
3. we removed the installation of `maven` used only when building JBMC
   that is now not happening.
@esteffin esteffin requested a review from a team as a code owner November 13, 2023 20:41
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ea34799) 79.10% compared to head (fc64f4f) 79.10%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8030   +/-   ##
========================================
  Coverage    79.10%   79.10%           
========================================
  Files         1699     1699           
  Lines       196508   196508           
========================================
  Hits        155446   155446           
  Misses       41062    41062           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NlightNFotis NlightNFotis merged commit a8de0b7 into diffblue:develop Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants