C front-end: ensure array type updates are consistent #7610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested review from
kroening,
chris-ryder,
peterschrammel and
remi-delmas-3000
as code owners
tautschnig
force-pushed
the
bugfixes/7608-array-size-nil
branch
2 times, most recently
from
ea2f7fa to
85af4f6
Compare
tautschnig
force-pushed
the
bugfixes/7608-array-size-nil
branch
from
85af4f6 to
1f013f5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #7610 +/- ##
===========================================
- Coverage 78.38% 78.24% -0.14%
===========================================
Files 1720 1720
Lines 187982 188328 +346
Branches 18474 18473 -1
===========================================
+ Hits 147346 147360 +14
- Misses 40636 40968 +332 ☔ View full report in Codecov by Sentry. |
peterschrammel
approved these changes
Mar 27, 2023
tautschnig
force-pushed
the
bugfixes/7608-array-size-nil
branch
2 times, most recently
from
0314f76 to
e00eb77
Compare
We must not end up in a situation where the symbol's array type is different from the type applied to symbol expressions in code. With the previous approach, support-function generation would alter the type after typechecking of code had already been completed. Instead, do as the C standard says: if the type is incomplete _at the end of a translation unit_, the (implicit) initializer makes it a one-element array. Fixes: diffblue#7608
tautschnig
force-pushed
the
bugfixes/7608-array-size-nil
branch
from
e00eb77 to
02099c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We must not end up in a situation where the symbol's array type is different from the type applied to symbol expressions in code. With the previous approach, support-function generation would alter the type after typechecking of code had already been completed.
Fixes: #7608