Fix various type conversion and deprecation warnings reported by Visual studio #2310
Conversation
tautschnig
requested review from
cesaro,
kroening,
mgudemann,
peterschrammel,
smowton and
thk123
as code owners
tautschnig
force-pushed
the
visual-studio-warnings
branch
2 times, most recently
from
69cd850 to
e389d29
Compare
| { | ||
| return class_index; | ||
| } | ||
| u1 get_name_and_type_index() const | ||
| u2 get_name_and_type_index() const | ||
| { |
src/util/pointer_offset_size.cpp
Outdated
| return -1; // we cannot distinguish the elements | ||
|
|
||
| return sub*i; | ||
| return sub * *size; | ||
| } |
There was a problem hiding this comment.
I really like (*size) here, otherwise looks a bit like a power in Verilog.
src/util/pointer_offset_size.cpp
Outdated
| return -1; // we cannot distinguish the elements | ||
|
|
||
| return sub*i; | ||
| return sub * *size; | ||
| } |
tautschnig
force-pushed
the
visual-studio-warnings
branch
2 times, most recently
from
2714dac to
c306c80
Compare
|
I have started factoring out parts into digestable PRs. I will keep using this one as my testbed to gather input from AppVeyor. No need for reviews, though. |
tautschnig
force-pushed
the
visual-studio-warnings
branch
2 times, most recently
from
fb8ccf7 to
2cadc86
Compare
tautschnig
force-pushed
the
visual-studio-warnings
branch
5 times, most recently
from
d07e1c3 to
98f8962
Compare
tautschnig
force-pushed
the
visual-studio-warnings
branch
2 times, most recently
from
808818b to
c52a4d7
Compare
|
[...]
Mostly the latter, but there are other PRs that still have higher priority to be cleaned up and merged before I can spend time on this one. |
Given that you are planning to raise separate PRs, rather than ever merging this one and that you can refer to the branch without keeping the PR open, are you ok with this PR being closed out for the moment? Just trying to keep the number of currently open PRs down. |
|
Going ahead with closing this PR as being very stale. Feel free to reopen this PR if you believe that closing this was a mistake - it will need a rebase on top of It will also probably need a rerun of everything on VS2019, given that this is what we are supporting on our CI platforms as well. |
tautschnig
requested review from
a team,
TGWDB and
remi-delmas-3000
as code owners
tautschnig
force-pushed
the
visual-studio-warnings
branch
from
03e6856 to
2f3ed10
Compare
These are never used (and their implementation was awkwardly summing up Booleans, yielding conversion warnings).
We can safely read signed values and don't need to defer the type conversion to the call site.
Visual Studio warns about signed/unsigned conversion and limited range of types.
Visual Studio warns about signed/unsigned conversion and limited range of types.
Visual Studio warns about signed/unsigned conversion and limited range of types.
Visual Studio warns about signed/unsigned conversion and limited range of types.
…d long long Visual Studio warns about signed/unsigned conversion and limited range of types.
This avoids conversion warnings with Visual Studio.
cmdlinet::parse has a different signature and we don't override it here. As an alternative option, we could rename functions.
Constructing the arguments in place triggers a warning with Visual Studio. Just construct them in a fixed order upfront and move each of them.
…em errors Treat all Visual Studio warnings except those that we cannot do anything about as errors.
tautschnig
force-pushed
the
visual-studio-warnings
branch
from
ff85b54 to
0ca98d2
Compare
Reviews appreciated, but this is still incomplete as I am trying to get updated results from AppVeyor.