feat(fetch): add response method. #947
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge code.
merge code
merge code.
merge code
|
api实现方式不符合预期 |
hiyuki
reviewed
Mar 9, 2022
packages/fetch/src/mock.js
Outdated
| // custom不存在时，进行url参数匹配 | ||
| const matched = (!test.custom) && doTest(configBackup, test).matched | ||
| if (isFunction(callback) && ((isFunction(test.custom) && test.custom(configBackup)) || matched)) { | ||
| let data = callback.call(config) |
There was a problem hiding this comment.
访问config需要通过this访问吗？建议别这样设计，直接显式传参就尅
There was a problem hiding this comment.
是滴，那我修改成显式调用哈
hiyuki
reviewed
Mar 9, 2022
packages/fetch/src/mock.js
Outdated
| for (let item of options) { | ||
| const { test, mock: callback } = item | ||
| // custom不存在时，进行url参数匹配 | ||
| const matched = (!test.custom) && doTest(configBackup, test).matched |
There was a problem hiding this comment.
把test.custom的处理也放在doTest中吧，外面就只需要调用doTest就可以，把proxy和validate中使用doTest的地方也修改一下
hiyuki
reviewed
Mar 9, 2022
packages/fetch/src/xfetch.js
Outdated
| @@ -81,6 +83,24 @@ export default class XFetch { | |||
| } | |||
| } | |||
|
|
|||
| setMock (options) { | |||
|
处理冲突 |
1 similar comment
|
处理冲突 |
hiyuki
reviewed
Mar 9, 2022
|
|
||
| if (this.mockOptions) { | ||
| let mockData = requestMock(this.mockOptions, config) | ||
| if (isThenable(mockData)) return mockData |
There was a problem hiding this comment.
mockData不能直接返回，我们的返回需要和真实response保持一致的数据结构
hiyuki
reviewed
Mar 9, 2022
|
|
||
| if (this.mockOptions) { | ||
| let mockData = requestMock(this.mockOptions, config) | ||
| if (isThenable(mockData)) return mockData |
There was a problem hiding this comment.
mockData不能直接返回，我们的返回需要和真实response保持一致的数据结构，以及需要处理跨平台差异（可调用目前已有的transformRes方法
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.