[feat]rn-relatons #1679
Open
[feat]rn-relatons #1679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiyuki
reviewed
Jan 9, 2025
| const root = rawOptions.options?.disableMemo ? proxy.effect.run() : useMemo(() => proxy.effect.run(), [proxy.stateVersion]) | ||
| const runRenderEffect = () => { | ||
| if (needRelationContext(rawOptions)) { | ||
| return createElement(RelationsContext.Provider, { |
hiyuki
reviewed
Jan 9, 2025
| @@ -117,6 +118,7 @@ global.currentInject.firstPage = ${JSON.stringify(firstPage)}\n` | |||
| content += `global.currentInject.getComponents = function () { | |||
| return ${shallowStringify(componentsMap)} | |||
| }\n` | |||
| content += `global.currentInject.componentPath = '/' + ${JSON.stringify(outputPath)}\n` | |||
hiyuki
reviewed
Jan 9, 2025
| }) | ||
| } | ||
|
|
||
| const RelationsContext = createContext(null) |
There was a problem hiding this comment.
context可以以outputPath为key存一系列
hiyuki
reviewed
Jan 9, 2025
| if (item.type?.__mpxBuiltIn) { // 如果是基础节点，继续向下查找 | ||
| return isChildNode(item, instance) | ||
| } else { | ||
| return item.type === instance.__getReactFunctionComponent() |
There was a problem hiding this comment.
光凭这个ctor也没办法判断当前的instance一定是child吧
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.