Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove deprecated fields/parameters DHIS2-18925 #19965

Merged
merged 10 commits into from
Feb 19, 2025
Merged

chore: remove deprecated fields/parameters DHIS2-18925 #19965

merged 10 commits into from
Feb 19, 2025

Conversation

teleivo
Copy link
Contributor

@teleivo teleivo commented Feb 18, 2025 •
edited
Loading

github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 18, 2025
View reviewed changes
.../java/org/hisp/dhis/webapi/controller/tracker/export/enrollment/EnrollmentRequestParams.java Outdated
@@ -63,23 +63,9 @@
@OpenApi.Property(defaultValue = "50")
private Integer pageSize;

@OpenApi.Property(defaultValue = "false")
private Boolean totalPages = false;
private boolean totalPages = false;

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
PageRequestParams.isTotalPages
Loading
; it is advisable to add an Override annotation.
...i/src/main/java/org/hisp/dhis/webapi/controller/tracker/export/event/EventRequestParams.java Outdated
@@ -73,23 +73,9 @@
@OpenApi.Property(defaultValue = "50")
private Integer pageSize;

@OpenApi.Property(defaultValue = "false")
private Boolean totalPages = false;
private boolean totalPages = false;

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
PageRequestParams.isTotalPages
Loading
; it is advisable to add an Override annotation.
...i/src/main/java/org/hisp/dhis/webapi/controller/tracker/export/event/EventRequestParams.java Outdated
// enabled
@OpenApi.Property(defaultValue = "true")
private Boolean paging;
private boolean paging = true;

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
PageRequestParams.isPaging
Loading
; it is advisable to add an Override annotation.
...a/org/hisp/dhis/webapi/controller/tracker/export/relationship/RelationshipRequestParams.java Outdated
@@ -55,23 +55,9 @@
@OpenApi.Property(defaultValue = "50")
private Integer pageSize;

@OpenApi.Property(defaultValue = "false")
private Boolean totalPages = false;
private boolean totalPages = false;

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
PageRequestParams.isTotalPages
Loading
; it is advisable to add an Override annotation.
@teleivo teleivo force-pushed the DHIS2-18925-next branch 2 times, most recently from 7e5cae5 to 660ec28 Compare February 18, 2025 16:02
@teleivo teleivo force-pushed the DHIS2-18925-next branch 2 times, most recently from 533c990 to 0aa59a2 Compare February 19, 2025 06:40
@teleivo teleivo marked this pull request as ready for review February 19, 2025 07:21
@teleivo teleivo requested review from ameenhere and zubaira February 19, 2025 07:33
@teleivo teleivo requested a review from a team as a code owner February 19, 2025 07:58
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

teleivo added a commit to dhis2/dhis2-docs that referenced this pull request Feb 19, 2025
@teleivo
docs: remove parameters deprecated in 41
c768a85 
https://github.com/dhis2/dhis2-releases/tree/master/releases/2.41#tracker

as they have been removed in 42
dhis2/dhis2-core#19965
@teleivo teleivo mentioned this pull request Feb 19, 2025
Merged
@teleivo teleivo merged commit 88c5c33 into master Feb 19, 2025
17 checks passed
@teleivo teleivo deleted the DHIS2-18925-next branch February 19, 2025 08:31
@teleivo teleivo mentioned this pull request Feb 19, 2025
Merged
teleivo added a commit to dhis2/dhis2-docs that referenced this pull request Feb 19, 2025
@teleivo
docs: remove parameters deprecated in 41 (#1504)
a748ff6 
https://github.com/dhis2/dhis2-releases/tree/master/releases/2.41#tracker

as they have been removed in 42
dhis2/dhis2-core#19965
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ameenhere ameenhere ameenhere approved these changes

@enricocolasante enricocolasante enricocolasante approved these changes

@muilpp muilpp Awaiting requested review from muilpp

@zubaira zubaira Awaiting requested review from zubaira

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@teleivo @ameenhere @enricocolasante @zubaira