chore: Remove obsolete rule-engine configuration #19910
Merged
+0
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We forgot to remove `system.program_rule.server_execution` configuration that was only used by old tracker API. In Tracker API the same behavior is now achieved using `skipRuleEngine` (https://docs.dhis2.org/en/develop/using-the-api/dhis-core-version-master/tracker.html#webapi_tracker_import_request_parameters)
|
teleivo
reviewed
Feb 12, 2025
| * Disable server-side program rule execution, can be 'on', 'off'. <br> | ||
| * (default: on) | ||
| */ | ||
| SYSTEM_PROGRAM_RULE_SERVER_EXECUTION("system.program_rule.server_execution", Constants.ON, false), |
There was a problem hiding this comment.
Does this need to be mentioned in the release notes 🤷🏻
There was a problem hiding this comment.
It should have been mentioned in 2.41 release notes.
I also updated the docs, I will check with @Philip-Larsen-Donnelly or @ameenhere what is the best way to add this information somewhere
teleivo
approved these changes
Feb 12, 2025
muilpp
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We forgot to remove
system.program_rule.server_executionconfiguration that was only used by old tracker API. In Tracker API the same behavior is now achieved usingskipRuleEngine(https://docs.dhis2.org/en/develop/using-the-api/dhis-core-version-master/tracker.html#webapi_tracker_import_request_parameters)