Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: metadata api to support sort case-insensitive [DHIS2-18857] #19865

Merged
merged 4 commits into from
Feb 18, 2025
Merged

fix: metadata api to support sort case-insensitive [DHIS2-18857] #19865

merged 4 commits into from
Feb 18, 2025

Conversation

vietnguyen
Copy link
Contributor

@vietnguyen vietnguyen commented Feb 6, 2025 •
edited
Loading

Issue

  • The metadata API query parameters support case-insensitive ordering, but the underlying JpaQueryEngine does not.

Fix

  • Modify JpaQueryEngine to support case-insensitive ordering by applying the order by lower(columnName)

Test

  • Added a controller test to verify the updated behavior.

@vietnguyen vietnguyen changed the title fix: metadata api to support sort iasc fix: metadata api to support sort case-insensitive [DHIS2-18857] Feb 6, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@larshelge larshelge merged commit c8aee8e into master Feb 18, 2025
17 checks passed
@larshelge larshelge deleted the DHIS2-18857-42 branch February 18, 2025 19:20
vietnguyen added a commit that referenced this pull request Feb 19, 2025
@vietnguyen
Revert "fix: metadata api to support sort iasc (#19865)"
bf84652 
This reverts commit c8aee8e.
@enricocolasante enricocolasante mentioned this pull request Feb 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larshelge larshelge larshelge approved these changes

@david-mackessy david-mackessy david-mackessy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vietnguyen @larshelge @david-mackessy