Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: manage Notifier storage usage [DHIS2-17998] (2.40) #19816

Draft
wants to merge 5 commits into
base: 2.40
Choose a base branch
from

Conversation

jbee
Copy link
Contributor

@jbee jbee commented Jan 30, 2025

cherry-picked from #19807

with a fair number of further conflicts to resolve manually.

I also had to go back to Java 11 undoing use of record and .toList() mostly.

* feat: manage Notifier storage usage [DHIS2-17998] (#19738)

* feat: gist for overview lists, limit setting [DHIS2-17998]

* refactor: NotifierStore implemented

* feat: clear and cap API and endpoints

* feat: cap for redis store

* fix: cap and clean consistency, log level filter for scheduling only

* chore: API cleanup, javadoc, some test fixes

* fix: notifier tests

* fix: hide transient empty in-memory stores in the API

* fix: update test assert with new message

* fix: remove notifier stubbing from mock test

* fix: e2e test assert for updated message

* fix: mock test setup, dependencies

* fix: add jackson core back in

* fix: exclude jackson core from dependency check

* fix: sonar issues

* test: notifier API tests for in-memory and redis

* fix: sonar warnings

* chore: fix typo

* chore: prevent null message logging + log cleanup [DHIS2-17998] (#19800)

* fix: maven dependencies + mock tests

* fix: add Long conversion

* fix: e2e test message expectations after change in wording
@jbee jbee self-assigned this Jan 30, 2025
@jbee jbee changed the title feat: manage Notifier storage usage [DHIS2-17998] (2.41) feat: manage Notifier storage usage [DHIS2-17998] (2.40) Jan 30, 2025
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
4 New issues
E Security Rating on New Code (required ≥ A)
1 New Vulnerabilities (required ≤ 0)
3 New Code Smells (required ≤ 0)
1 New Critical Issues (required ≤ 0)
1 New Blocker Issues (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant