fix: Stop server startup when no server base url [DHIS2-17980] #18580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
larshelge
approved these changes
Dec 3, 2024
teleivo
reviewed
Feb 20, 2025
| // --------------------------------------------------------------------- | ||
| // If mandatory config is not present stop startup | ||
| // --------------------------------------------------------------------- | ||
| String serverBaseUrl = this.properties.getProperty(ConfigurationKey.SERVER_BASE_URL.getKey()); |
There was a problem hiding this comment.
Just a thought: I assume there are other required configs. Could we declare that in ConfigurationKey with a boolean required and fail startup if any of these required ones without a default have no value? We might awkwardly fail at some later point when a user triggers code reading the config key for the first time 😅
There was a problem hiding this comment.
Yep, that's a good idea for a new feature. This PR has fallen through the cracks. Hope to get back to this smaller fix before the release.
larshelge
approved these changes
Mar 4, 2025
|
A few conflicts need resolve @david-mackessy . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.